[RFA] Build failure fix: Python troubles on non-python targets...

Tom Tromey tromey@redhat.com
Thu May 28 15:38:00 GMT 2009


>>>>> "Pierre" == Pierre Muller <muller@ics.u-strasbg.fr> writes:

Pierre> On DJGPP,
Pierre> I now get this failure:
[...]

Sorry about that.

Pierre> The following two changes fixes compilation for me:
Pierre> Is this patch OK?

Nearly...

Pierre> +
Pierre> +#ifdef HAVE_PYTHON
Pierre> +
Pierre>  #include "python.h"
Pierre>  #include "python-internal.h"
 
This should unconditionally include python.h.  So, the conditional
needs to be moved down a few lines.  It is ok to include python.h even
if Python is not available; and in this case it is desirable so that
the declarations are picked up (and thus checked against the
definitions).

Ok with that change.  Thanks.

Tom



More information about the Gdb-patches mailing list