[commit/Ada] Fix crash printing packed record containing a packed array

[Joel Brobecker]

This was noticed when debugging on sparc-elf using the GDB simulator.
A testcase is provided as well.

There was a couple of issues:
  - The first is documented through comments in the code, so I won't
    repeat them here;
  - The second was a tiny bug in the extraction of the packed array
    value...

2009-03-12  Joel Brobecker  <brobecker@adacore.com>

        Fix crash printing packed record with packed array.

        * ada-lang.c (ada_modulus_from_name): New function.
        (ada_modulus): In the case where the type length is bigger than
        the size of the type used to hold the bounds, try determining
        the modulus from the type name.
        (ada_value_primitive_packed_val): Fix bug in the computation of
        ntarg causing an out-of-buffer invalid access.

2009-03-12  Joel Brobecker  <brobecker@adacore.com>

        * gdb.ada/mod_from_name: New testcase.

Re-tested on amd64-linux. Checked in.

-- 
Joel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 03-ada-modulus.diff
Type: text/x-diff
Size: 2396 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20090312/39976a0c/attachment.bin>
-------------- next part --------------
--  Copyright 2009 Free Software Foundation, Inc.
--
--  This program is free software; you can redistribute it and/or modify
--  it under the terms of the GNU General Public License as published by
--  the Free Software Foundation; either version 3 of the License, or
--  (at your option) any later version.
--
--  This program is distributed in the hope that it will be useful,
--  but WITHOUT ANY WARRANTY; without even the implied warranty of
--  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
--  GNU General Public License for more details.
--
--  You should have received a copy of the GNU General Public License
--  along with this program.  If not, see <http://www.gnu.org/licenses/>.

procedure Foo is

   type Small is range -32 .. 31;

   type SomePackedArray is array (Integer range <>) of Small;
   pragma Pack (SomePackedArray);

   type SomePackedRecord is record
      Y: SomePackedArray (1 .. 10);
   end record;
   pragma Pack (SomePackedRecord);

   Suite : SomePackedArray := (-1, -2, -3, -4, -5, -6, -7, -8, -9, -10);
   XP: SomePackedRecord := (Y => Suite);

   Slice : SomePackedArray renames XP.Y (3 .. 5);

begin
   Slice (4) := 4;  --  START
end Foo;

-------------- next part --------------
# Copyright 2009 Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program.  If not, see <http://www.gnu.org/licenses/>.

if $tracelevel then {
    strace $tracelevel
}

load_lib "ada.exp"

set testdir "mod_from_name"
set testfile "${testdir}/foo"
set srcfile ${srcdir}/${subdir}/${testfile}.adb
set binfile ${objdir}/${subdir}/${testfile}

file mkdir ${objdir}/${subdir}/${testdir}
if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug ]] != "" } {
  return -1
}

gdb_exit
gdb_start
gdb_reinitialize_dir $srcdir/$subdir
gdb_load ${binfile}

set bp_location [gdb_get_line_number "START" ${testdir}/foo.adb]
if ![runto "foo.adb:$bp_location" ] then {
  perror "Couldn't run ${testfile}"
  return
} 

gdb_test "print xp" \
         "= \\(y => \\(-1, -2, -3, -4, -5, -6, -7, -8, -9, -10\\)\\)" \
         "print xp"