[commit/Ada] Fix crash when printing 'first/'last of type

Joel Brobecker brobecker@adacore.com
Thu Mar 12 23:47:00 GMT 2009


This patch fixes a debugger crash when trying to print the 'first or
'last value of type Short_Integer when this type is not used in the
program (or debug info for this type is not available).

2009-03-12  Joel Brobecker  <brobecker@adacore.com>

        Fix segfault when printing short_integer'last.

        * ada-lang.c (ada_find_any_type): Search in the primitive types
        if a symbol could not be found.

A testcase is also provided.

2009-03-12  Joel Brobecker  <brobecker@adacore.com>

        * gdb.ada/tick_last_segv: New testcase.

Tested on amd64-linux. Checked in.

-- 
Joel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 02-tick-last.diff
Type: text/x-diff
Size: 598 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20090312/e50827b5/attachment.bin>
-------------- next part --------------
--  Copyright 2009 Free Software Foundation, Inc.
--
--  This program is free software; you can redistribute it and/or modify
--  it under the terms of the GNU General Public License as published by
--  the Free Software Foundation; either version 3 of the License, or
--  (at your option) any later version.
--
--  This program is distributed in the hope that it will be useful,
--  but WITHOUT ANY WARRANTY; without even the implied warranty of
--  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
--  GNU General Public License for more details.
--
--  You should have received a copy of the GNU General Public License
--  along with this program.  If not, see <http://www.gnu.org/licenses/>.

procedure foo is
begin
   null;
end foo;
-------------- next part --------------
# Copyright 2009 Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program.  If not, see <http://www.gnu.org/licenses/>.

if $tracelevel then {
    strace $tracelevel
}

load_lib "ada.exp"

set testdir "tick_last_segv"
set testfile "${testdir}/foo"
set srcfile ${srcdir}/${subdir}/${testfile}.adb
set binfile ${objdir}/${subdir}/${testfile}

file mkdir ${objdir}/${subdir}/${testdir}
if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug ]] != "" } {
  return -1
}

gdb_exit
gdb_start
gdb_reinitialize_dir $srcdir/$subdir
gdb_load ${binfile}

# Make sure that evaluating the 'First and 'Last attributes on
# a "primitive type" (a predefined type for which GDB also creates
# pre-defined types) does not cause the debugger to crash.
# The actual value printed is of no interest in this testcase.

gdb_test "print short_integer'first" \
         "= -\[0-9\]+" \
         "print short-integer'first"

gdb_test "print short_integer'last" \
         "= \[0-9\]+" \
         "print short-integer'last"



More information about the Gdb-patches mailing list