[patch] Correct `gcc -D' macros get ignored (PR 9873)
Joel Brobecker
brobecker@adacore.com
Mon Mar 9 18:41:00 GMT 2009
> 2009-03-09 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> PR gdb/9873:
> * dwarf2read.c (dwarf_decode_macros): New variable `at_commandline'.
> Move the variable `macinfo_type' out of the loop. Create a new
> processing pass before the current one to pre-create `current_file'.
> New complaint on misplaced zero/non-zero definitions/includes.
> Skip first DW_MACINFO_start_file with `at_commandline' set.
This is OK, with one tiny typo (and I'm probably the one responsible
for it).
> Sure I find your text better although its first line does not follow the GNU
> Coding Style directive `[...] please write complete sentences [...]'.
> Used your text.
Are you refering to the "First pass:"? I think it's OK.
> OK although it was catching both inconsistencies so it has to be written as
>
> if ((line == 0 && !at_commandline) || (line != 0 && at_commandline))
Right!
> + associated to base file.
^^^ "the" base file...
Cheers,
--
Joel
More information about the Gdb-patches
mailing list