[patch] Fix a reread_symbols regression by mmap [Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.]

[Jan Kratochvil]

On Tue, 23 Jun 2009 20:08:41 +0200, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> 
> Jan> while sure your patch is great it has a regression.  Assuming a regression
> Jan> reproducer needs to link GDB with -lmcheck (but did verify it).
                                                      ^I  ^not

> This is ok.

Checked-in.
	http://sourceware.org/ml/gdb-cvs/2009-06/msg00148.html


> Jan> +		 Try to keep the freeing order compatible with free_objfile.  */
> 
> It seems like it would be nice to have a single function here.

IMO the whole `struct objfile' should replaced by a new one (instead of its
in-place patching).  Which will probably have other dependencies...


Thanks,
Jan