[PING][RFA-v2] Fix a windows bug if two watchpoints are used

Pierre Muller muller@ics.u-strasbg.fr
Tue Jun 16 22:43:00 GMT 2009



> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Eli Zaretskii
> Envoyé : Thursday, June 04, 2009 5:23 PM
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: [RFA-v2] Fix a windows bug if two watchpoints are used
> 
> > From: "Pierre Muller" <muller@ics.u-strasbg.fr>
> > Cc: <gdb-patches@sourceware.org>
> > Date: Thu, 4 Jun 2009 16:51:51 +0200
> > Content-Language: en-us
> >
> >   Maybe we should use
> >    ALL_DEBUG_REGISTERS(i)
> >      {
> >        if (I386_DR_WATCH_HIT (i)
> > 		&& !I386_DR_VACANT(i)
> > 		&& I386_DR_GET_RW_LEN (i) != 0)
> 
> I have no objections to adding the test for I386_DR_VACANT.

  Here also, I don't know if there still is an official
maintainer for i386-nat.c code, or is 
Eli's approval enough for this?

Pierre



More information about the Gdb-patches mailing list