[rfc] Eliminate duplicated logic with decimal operations

Thiago Jung Bauermann bauerman@br.ibm.com
Wed Jun 3 14:27:00 GMT 2009


Hi Uli,

Em Qui, 2009-05-14 às 13:32 +0200, Ulrich Weigand escreveu:
> The patch below removes steps 2 and 3 and only keeps the first
> conversion to decNumber.  This applies to both decimal_binop and 
> decimal_compare.
> 
> Thiago, any thoughts on this?  Do you agree that those conversions
> are unnecessary?

Thanks for this improvement! I agree with you, those are silly
conversions.

> Tested on powerpc64-linux with no regressions.

Silly question: you ran the testsuite with a DFP-capable compiler
right? :-)

dfp-exprs.exp has promotion tests, so your patch is certainly good.
-- 
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center



More information about the Gdb-patches mailing list