[RFA] trailing backslash in top-level Makefile

Jerome Guitton guitton@adacore.com
Tue Jun 2 16:34:00 GMT 2009


The top-level Makefile.in may generate a trailing backslash at the end
of the target "all" (if gcc-bootstrap is false). Something like that:

[...]
all:
        @: $(MAKE); $(unstage)
        @r=`${PWD_COMMAND}`; export r; \
        s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \
          $(MAKE) $(RECURSE_FLAGS_TO_PASS) all-host all-target \

.PHONY: all-build
[...]


On most system, that's fine. However, this is rejected by some shells.
For example, the system bash on some solaris systems:

ostende% bash --version 
GNU bash, version 2.03.0(1)-release (sparc-sun-solaris)
Copyright 1998 Free Software Foundation, Inc.
> bash -c "ls \\"

bash: -c: line 2: syntax error: unexpected end of file

The patch in attachment would fix the problem. It's a little bit ugly
though. "echo" is used as a "nop". Would someone have a better idea to fix
the problem?


2009-06-02  Jerome Guitton  <guitton@adacore.com>

	* Makefile.tpl: Remove a trailing backslash.
	* Makefile.in: Regenerate.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: toplevel.diff
Type: text/x-diff
Size: 1200 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20090602/38085934/attachment.bin>


More information about the Gdb-patches mailing list