[RFC] small change for better error reporting in remote.c
Michael Snyder
msnyder@vmware.com
Fri Jul 31 21:00:00 GMT 2009
drow@false.org wrote:
> On Wed, Jul 29, 2009 at 04:59:36PM -0700, Michael Snyder wrote:
>> @@ -5189,7 +5192,10 @@ store_registers_using_G (const struct re
>> /* remote_prepare_to_store insures that rsa->sizeof_g_packet gets
>> updated. */
>> bin2hex (regs, p, rsa->sizeof_g_packet);
>> - remote_send (&rs->buf, &rs->buf_size);
>> + putpkt (rs->buf);
>> + getpkt (&rs->buf, &rs->buf_size, 0);
>> + if (rs->buf[0] == 'E')
>> + error (_("Could not write registers"));
>> }
>>
>> /* Store register REGNUM, or all registers if REGNUM == -1, from the contents
>
> Can't you use packet_ok like elsewhere? Otherwise OK.
You may not realize it, but you're asking for a much bigger change.
There is no struct packet_config for the 'G' packet. I'll have to
change set_registers_using_G from void to int, so that it can
return failure if the 'G' packet is unsupported.
But I'll begin working on it, unles I hear "never mind"
from you... ;-)
Michael
More information about the Gdb-patches
mailing list