[RFC/RFA] -break-insert -d

Pedro Alves pedro@codesourcery.com
Mon Jan 26 18:47:00 GMT 2009


On Monday 26 January 2009 13:14:24, Vladimir Prus wrote:
> 
> Presently, the -break-insert command always creates enabled breakpoint. Marc has noticed
> that in Eclipse, with non-stop mode, this case lead to races. Specifically, if a breakpoint
> is disabled in UI, then Eclipse first inserts a breakpoint, and then makes it disabled. So,
> there's a window when the breakpoint is inserted in the target. One possible solution is
> to modify Eclipse to never insert disabled breakpoint in GDB. However, this special-casing
> has to be done in every frontend, and GDB-side solution is better. The below patch implements
> new -d option to the -break-insert command, which causes the newly created breakpoints to be
> disabled.
> 
> Is the breakpoint.c change OK. 

Looks fine to me.

> Any comments on MI changes? 

-- 
Pedro Alves



More information about the Gdb-patches mailing list