[PATCH 1/4] catch syscall -- try 4 -- Architecture-independent part
Pedro Alves
pedro@codesourcery.com
Mon Jan 26 00:51:00 GMT 2009
One quick comment before bedtime :-),
On Monday 26 January 2009 00:30:31, Sérgio Durigan Júnior wrote:
> + printf_filtered (_("\nCatchpoint %d ("), b->number);
> +
> + if (last.kind == TARGET_WAITKIND_SYSCALL_ENTRY)
> + printf_filtered (_("call to "));
> + else
> + printf_filtered (_("returned from "));
> +
> + printf_filtered (_("syscall "));
> +
> + if (s.name == NULL)
> + printf_filtered (_("%d"), b->syscall_number);
> + else
> + printf_filtered (_("'%s'"), s.name);
> + printf_filtered (_("), "));
> +
Could you please combine this into full sentences, please? It
will be better for translation, and probably clearer to read. Say:
struct cleanup *old_chain;
char *syscall_id;
if (s.name == NULL)
syscall_id = xstrprintf ("%d", b->syscall_number);
else
syscall_id = xstrprintf ("'%s'", s.name);
old_chain = make_cleanup (xfree, syscall_id);
if (last.kind == TARGET_WAITKIND_SYSCALL_ENTRY)
printf_filtered (_("\nCatchpoint %d (call to syscall %s), "),
syscall_id);
else
printf_filtered (_("\nCatchpoint %d (returned from %s), "),
syscall_id);
do_cleanups (old_chain);
--
Pedro Alves
More information about the Gdb-patches
mailing list