[rfc] Remove deprecated_safe_get_selected_frame call from read_var_value

Ulrich Weigand uweigand@de.ibm.com
Thu Jan 15 15:40:00 GMT 2009


Daniel Jacobowitz wrote:
> On Wed, Jan 14, 2009 at 04:31:51PM +0100, Ulrich Weigand wrote:
> > 
> > > ChangeLog:
> > > 
> > > 	* value.h (address_of_variable): Add prototype.
> > > 	(locate_var_value): Remove prototype.
> > > 
> > > 	* findvar.c (read_var_value): Do not attempt to default frame
> > > 	to selected frame.
> > > 	(locate_var_value): Remove function.
> > > 	* valops.c (value_of_variable): Retrieve selected frame for
> > > 	symbols that require a frame when called with NULL block.
> > > 	* valops.c (address_of_variable): New function.
> > > 
> > > 	* eval.c (evaluate_subexp_for_address): Call address_of_variable
> > > 	instead of calling locate_var_value.
> > > 	(evaluate_subexp_with_coercion): Likewise.
> > 
> > I've noticed a couple of tests that are now obsolete.  Please consider
> > the following patch instead.  Re-tested on powerpc-linux.
> 
> Looks reasonable to me.

Thanks for the review!

I've checked this in now.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com



More information about the Gdb-patches mailing list