Patch for PR 9399

Chris Moller cmoller@redhat.com
Thu Dec 10 18:33:00 GMT 2009


I fixed all the stuff you mention below, plus I added an FSF copyright 
notice to virtfunc2.cc--somehow, I forgot to do that yesterday--and 
fixed the fix to valops.c.  (The original version worked in archer--more 
or less by pure accident, I suspect--but failed in FSF.--I'd forgotten 
to make sure that type names were non-null before calling strcmp on 
them.  Fixed now.)

I've attached the new patch file and virtfunc2.* files.

On 12/10/09 11:59, Tom Tromey wrote:
>>>>>> "Chris" == Chris Moller<cmoller@redhat.com>  writes:
>>>>>>              
>
> Chris>  The attached stuff is a patch for PR9399:
>
> Chris>  I've assigned that bug to myself.  If you're happy with the patch, let
> Chris>  me know and I'll close the bug.  (Or do whatever you usually do...)
>
> Yeah, what I do is set the target milestone to 7.1 and close as FIXED
> after the patch is committed.
>
> Chris>  +   /* Check to see if any kind of cast is necessary; if not, punt.
> Chris>  +      (Specifically not using strcmp_iw() because no other comparisons against
> Chris>  +      TYPE_NAME() use it.  They all use standard strcmp() instead.) */
>
> Delete this comment.
>
> Chris>  /* This test script is part of GDB, the GNU debugger.
>
> Chris>     Copyright 1993, 1994, 1997, 1998, 1999, 2003, 2004, 2009
>
> Just 2009.
>
> Chris>  # Copyright 1992, 1994, 1995, 1996, 1997, 1998, 1999, 2001, 2002, 2003, 2004,
> Chris>  # 2006, 2007, 2008, 2009 Free Software Foundation, Inc.
>
> Likewise.
>
> This is ok with those changes.  Thanks.
>
> Tom
>    

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: pr9399.patch
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20091210/19de7f68/attachment.ksh>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: virtfunc2.cc
Type: text/x-c++src
Size: 1096 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20091210/19de7f68/attachment.bin>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: virtfunc2.exp
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20091210/19de7f68/attachment-0001.ksh>


More information about the Gdb-patches mailing list