[RFC] Add support for Renesas RX architecture

Joel Brobecker brobecker@adacore.com
Fri Dec 4 17:38:00 GMT 2009

> I'll note up front that there's one #if 0 in rx-tdep.c.  I'd prefer to
> leave it there until Nick and I get all of the kinks worked out of
> the debug info.  I'm willing to remove it though if there are objections
> to having it in new code.

I usually prefer to avoid #if 0 code, but the comment is definitely
useful.  In this particular case, I don't think it's so bad, although,
IMO, the same effect could have been achieved without the #if 0, just
the comment (enabling the dwarf2 unwinders is standard, so it's not
like we need the reminder). Anyway, I'm personally OK, since I presume
that this in the TODO list to get fixed as some point in the near/medium

> Comments?
> 	* configure.tgt: Add rx-*-elf target.
> 	* rx-tdep.c: New target.

Yes. Great code, very clean.  Please go ahead and commit. I think this
also deserves a NEWS entry (you can send it as a separate patch for Eli).

Nice to see someone using the prologue-value infrastructure too, btw.


More information about the Gdb-patches mailing list