Simplify MI breakpoint setting

Tom Tromey tromey@redhat.com
Fri Aug 7 18:52:00 GMT 2009


>>>>> "Volodya" == Vladimir Prus <vladimir@codesourcery.com> writes:

Volodya> Further, set_breakpoint appears to be trivial and useless
Volodya> wrapper over break_command_really. This patch cleans that
Volodya> up. Are breakpoint.{c,h} changes OK?

I think the point of this is not to expose all the parameters of
break_command_really outside of breakpoint.c.

So, unless there is a problem with the current approach, I would prefer
not to change it.

In the alternative, if somebody does want to approve this, I would like
to recommend renaming break_command_really, as I don't think that is a
very good name for a public function.

Tom



More information about the Gdb-patches mailing list