[PATCH 2/3] catch syscall -- try 5 -- XML support

[Sérgio Durigan Júnior]

Hi Eli,

On Sat, 2009-04-25 at 11:48 +0300, Eli Zaretskii wrote:
> > From: =?ISO-8859-1?Q?S=E9rgio?= Durigan =?ISO-8859-1?Q?J=FAnior?= <sergiodj@linux.vnet.ibm.com>
> > Date: Wed, 22 Apr 2009 21:33:03 -0300
> > 
> > gdb/ChangeLog:
> > 
> > 2009-04-22  Sergio Durigan Junior <sergiodj@linux.vnet.ibm.com>
> > 
> > 	* syscalls/gdb-syscalls.dtd: New definition file for syscall's XML
> > 	support.
> > 	* syscalls/i386-syscalls.xml: New file for i386 syscalls.
> > 	* syscalls/ppc-syscalls.xml: New file for PPC syscalls.
> > 	* syscalls/ppc64-syscalls.xml: New file for PPC64 syscalls.
> 
> The last 3 entries name the files incorrectly, and also do not say
> that the lists are for GNU/Linux systems that use these hardware
> architectures.

Ops, sorry.  I didn't notice that it was wrong, it's an old version of
the ChangeLog.

> > diff --git a/gdb/syscalls/i386-linux.xml b/gdb/syscalls/i386-linux.xml
> > new file mode 100644
> > index 0000000..6f2beee
> > --- /dev/null
> > +++ b/gdb/syscalls/i386-linux.xml
> > @@ -0,0 +1,334 @@
> > +<?xml version="1.0"?>
> > +<!-- Copyright (C) 2007, 2008 Free Software Foundation, Inc.
> > +
> > +     Copying and distribution of this file, with or without modification,
> > +     are permitted in any medium without royalty provided the copyright
> > +     notice and this notice are preserved.  -->
> > +
> > +<!DOCTYPE feature SYSTEM "gdb-syscalls.dtd">
> > +
> > +<syscalls_info>
> > +  <syscall name="restart_syscall" number="0"/>
> 
> Where does this information come from?  If there's some system file
> from which you gleaned this, I'd suggest to name it here.  This is so
> someone in the future could update this database per the OS
> development.

Oh, sure.  Here goes a refreshed version of the patch containing the
changes.  I'll address the other comments (in the other patches) later
today.

Thank you,

-- 
Sérgio Durigan Júnior
Linux on Power Toolchain - Software Engineer
Linux Technology Center - LTC
IBM Brazil

gdb/ChangeLog:

2009-04-25  Sergio Durigan Junior <sergiodj@linux.vnet.ibm.com>

	* syscalls/gdb-syscalls.dtd: New definition file for syscall's XML
	support.
	* syscalls/i386-linux.xml: New file containing information about
	syscalls for GNU/Linux systems that use i386 architecture.
	* syscalls/ppc-linux.xml: New file containing information about
	syscalls for GNU/Linux systems that use PPC architecture.
	* syscalls/ppc64-linux.xml: New file containing information about
	syscalls for GNU/Linux systems that use PPC64 architecture.
	* xml-syscall.c: New file containing functions for manipulating
	syscall's XML files.
	* xml-syscall.h: New file, exporting the functions above mentioned.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: catch-syscall-xml-part.patch
Type: text/x-patch
Size: 54960 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20090425/f4172dd8/attachment.bin>