RFA: implement all missing macro expansion features

Joel Brobecker brobecker@adacore.com
Sun Sep 21 06:08:00 GMT 2008


> I think this patch addresses all your concerns.

Agreed.

> 2008-09-20  Tom Tromey  <tromey@redhat.com>
> 
> 	* macrocmd.c (extract_identifier): Add is_parameter argument.
> 	(macro_define_command): Update.
> 	(macro_undef_command): Likewise.
> 	* macroexp.c (stringify): New function.
> 	(find_parameter): Likewise.
> 	(gather_arguments): Add nargs argument.  Handle varargs.
> 	(substitute_args): Add is_varargs and va_arg_name arguments.
> 	Handle varargs, splicing, stringification.  Use find_parameter.
> 	(expand): Handle varargs.

> 2008-09-20  Tom Tromey  <tromey@redhat.com>
> 
> 	* gdb.base/macscp.exp: Add tests for stringification, splicing,
> 	and varargs.

Please wait another couple of days to give others a final chance
to provide their feedback, and then commit.

-- 
Joel



More information about the Gdb-patches mailing list