[patch] Fix a crash on NULL event_thread

Daniel Jacobowitz drow@false.org
Wed Sep 17 18:04:00 GMT 2008


On Sat, Sep 13, 2008 at 12:12:27AM +0200, Jan Kratochvil wrote:
> 2008-09-13  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	Fix a crash on uninitialized ECS->EVENT_THREAD for a newly found thread.
> 	* infrun.c (wait_for_inferior): Move this ECS->EVENT_THREAD
> 	initialization ...
> 	(fetch_inferior_event): ... and this ECS->EVENT_THREAD initialization
> 	...
> 	(handle_inferior_event): ... here after ADD_THREAD together with the
> 	local ADJUST_PC_AFTER_BREAK call.

Please move the reinit_frame_cache call so it is still right after
adjust_pc_after_break.  Also, no need to capitalize
adjust_pc_after_break; this is like the texinfo @var{} markup.  You
capitalize FOO when you mean "the value of a variable named foo",
but the name of the variable is still "foo".

Otherwise looks OK, thanks.

-- 
Daniel Jacobowitz
CodeSourcery



More information about the Gdb-patches mailing list