[reverse RFA] no singlestep-over-BP in reverse

[Michael Snyder]

Daniel Jacobowitz wrote:
> On Mon, Sep 15, 2008 at 11:31:33AM -0700, Michael Snyder wrote:
>> When we're stopped at a breakpoint and we want to
>> continue in reverse, we're not actually going to
>> execute the instruction at the breakpoint -- we're
>> going to de-execute the previous instruction.
>>
>> Therefore there's no need to singlestep before
>> inserting breakpoints.  In fact it would be a bad
>> idea to do so, because if there is a breakpoint at
>> the previous instruction, we WANT to hit it.
>>
>> Note that this patch is to be applied to the reverse branch.
> 
> If there is a breakpoint on the previous instruction, will you hit it
> before or after de-executing that instruction?  It seems like this
> logic should be somehow still necessary... but I can't put my finger
> on when.

The attached test does just that -- and it passes on three
targets that can go in reverse (teawater's, gdb-freeplay,
and the as yet unreleased VMware implementation).

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: consecutive-reverse.exp
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20080916/88f8cf69/attachment.ksh>