RFA: regression from print refactoring (was : mi/2549: data-list-register-values igonores the format parameter)

Vladimir Prus vladimir@codesourcery.com
Fri Nov 14 15:12:00 GMT 2008


Tom Tromey wrote:

>>>>>> "Nick" == Nick Roberts <nickrob@snap.net.nz> writes:
> 
> Nick> Why not add the tests below?  There were three failures before
> Nick> your change and they all pass after it.  They're pretty basic,
> Nick> and I don't know if there are any architectures for which they
> Nick> wouldn't work, but they would at least prevent this regression
> Nick> from occurring again.
> 
> Here's the complete patch.
> 
> Built & regtested on x86-64 (compile farm).
> 
> Please review.

This looks fine to me.

Thanks,
Volodya




More information about the Gdb-patches mailing list