RFA: Patch: implement missing macro functions

Eli Zaretskii eliz@gnu.org
Mon May 26 16:18:00 GMT 2008


> Cc: pedro@codesourcery.com, gdb-patches@sourceware.org
> From: Tom Tromey <tromey@redhat.com>
> Date: Fri, 23 May 2008 15:07:56 -0600
> 
> I fixed all the macro-related uses of @command.

Thanks.

> Here's a new patch.  Let me know what you think.

It's okay, but for a single minor nit:

> +macro define
> +macro list
> +macro undef
> +  These commands are now implemented.  These allow macros to be
> +  defined, undefined, and listed interactively.

I think we should delete the first sentence.  Users who read NEWS do
not know that these commands were documented, but not implemented.
Just saying "These commands allow macros to be defined, undefined, and
listed interactively from within GDB." is enough

Thanks.



More information about the Gdb-patches mailing list