[commit/obvious] various minor fixes
Thiago Jung Bauermann
bauerman@br.ibm.com
Sat May 3 15:25:00 GMT 2008
Hi,
I just committed the following. I checked out the insight module and
checked if show_stack_frame was used there, just in case.
--
[]'s
Thiago Jung Bauermann
Software Engineer
IBM Linux Technology Center
2008-05-03 Thiago Jung Bauermann <bauerman@br.ibm.com>
* breakpoint.c (create_exception_catchpoint): Remove prototype
for already deleted function.
* breakpoint.h (ep_is_exception_catchpoint): Likewise.
* frame.h (show_stack_frame): Remove prototype.
* stack.c (show_stack_frame): Remove empty, unused function.
* source.c (symtab_to_fullname, print_source_lines): Small fix
in comment.
* value.c (show_values): Update comments to mention "show values"
command instead of "info history".
=== modified file 'gdb/breakpoint.c'
--- gdb/breakpoint.c 2008-05-03 05:20:48 +0000
+++ gdb/breakpoint.c 2008-05-03 05:33:04 +0000
@@ -188,10 +188,6 @@ static char *ep_parse_optional_if_clause
static char *ep_parse_optional_filename (char **arg);
-static void create_exception_catchpoint (int tempflag, char *cond_string,
- enum exception_event_kind ex_event,
- struct symtab_and_line *sal);
-
static void catch_exception_command_1 (enum exception_event_kind ex_event,
char *arg, int tempflag, int from_tty);
=== modified file 'gdb/breakpoint.h'
--- gdb/breakpoint.h 2008-05-03 05:20:48 +0000
+++ gdb/breakpoint.h 2008-05-03 05:33:04 +0000
@@ -684,8 +684,6 @@ extern void breakpoint_re_set (void);
extern void breakpoint_re_set_thread (struct breakpoint *);
-extern int ep_is_exception_catchpoint (struct breakpoint *);
-
extern struct breakpoint *set_momentary_breakpoint
(struct symtab_and_line, struct frame_id, enum bptype);
=== modified file 'gdb/frame.h'
--- gdb/frame.h 2008-05-03 05:20:48 +0000
+++ gdb/frame.h 2008-05-03 05:33:04 +0000
@@ -645,8 +645,6 @@ extern void show_and_print_stack_frame (
extern void print_stack_frame (struct frame_info *, int print_level,
enum print_what print_what);
-extern void show_stack_frame (struct frame_info *);
-
extern void print_frame_info (struct frame_info *, int print_level,
enum print_what print_what, int args);
=== modified file 'gdb/source.c'
--- gdb/source.c 2008-04-21 16:12:57 +0000
+++ gdb/source.c 2008-05-03 05:33:05 +0000
@@ -1046,11 +1046,11 @@ open_source_file (struct symtab *s)
/* Finds the fullname that a symtab represents.
- If this functions finds the fullname, it will save it in ps->fullname
+ If this functions finds the fullname, it will save it in s->fullname
and it will also return the value.
If this function fails to find the file that this symtab represents,
- NULL will be returned and ps->fullname will be set to NULL. */
+ NULL will be returned and s->fullname will be set to NULL. */
char *
symtab_to_fullname (struct symtab *s)
{
@@ -1421,7 +1421,7 @@ print_source_lines_base (struct symtab *
}
/* Show source lines from the file of symtab S, starting with line
- number LINE and stopping before line number STOPLINE. If this is the
+ number LINE and stopping before line number STOPLINE. If this is
not the command line version, then the source is shown in the source
window otherwise it is simply printed */
=== modified file 'gdb/stack.c'
--- gdb/stack.c 2008-05-03 05:20:48 +0000
+++ gdb/stack.c 2008-05-03 05:33:05 +0000
@@ -738,14 +738,6 @@ print_frame (struct frame_info *frame, i
do_cleanups (old_chain);
}
-/* Show the frame info. If this is the tui, it will be shown in the
- source display otherwise, nothing is done. */
-
-void
-show_stack_frame (struct frame_info *frame)
-{
-}
-
/* Read a frame specification in whatever the appropriate format is
from FRAME_EXP. Call error(), printing MESSAGE, if the
=== modified file 'gdb/value.c'
--- gdb/value.c 2008-05-03 05:20:48 +0000
+++ gdb/value.c 2008-05-03 05:33:05 +0000
@@ -665,14 +665,14 @@ show_values (char *num_exp, int from_tty
if (num_exp)
{
- /* "info history +" should print from the stored position.
- "info history <exp>" should print around value number <exp>. */
+ /* "show values +" should print from the stored position.
+ "show values <exp>" should print around value number <exp>. */
if (num_exp[0] != '+' || num_exp[1] != '\0')
num = parse_and_eval_long (num_exp) - 5;
}
else
{
- /* "info history" means print the last 10 values. */
+ /* "show values" means print the last 10 values. */
num = value_history_count - 9;
}
@@ -687,12 +687,12 @@ show_values (char *num_exp, int from_tty
printf_filtered (("\n"));
}
- /* The next "info history +" should start after what we just printed. */
+ /* The next "show values +" should start after what we just printed. */
num += 10;
/* Hitting just return after this command should do the same thing as
- "info history +". If num_exp is null, this is unnecessary, since
- "info history +" is not useful after "info history". */
+ "show values +". If num_exp is null, this is unnecessary, since
+ "show values +" is not useful after "show values". */
if (from_tty && num_exp)
{
num_exp[0] = '+';
More information about the Gdb-patches
mailing list