[RFA] bpstat_do_actions in one place

Daniel Jacobowitz drow@false.org
Fri May 2 02:58:00 GMT 2008


On Thu, Apr 24, 2008 at 07:02:03PM +0300, Vladimir Prus wrote:
> 
> This patch, to be applied on top of the "Use observers to report stop events."
> make async code call bpstat_do_action in the event handler, to make sure that
> it's always called.
> 
> OK?

OK.

> +      /* If there's an error doing breakpoint commands, we don't
> +	 want to throw -- continuation might still do something.  */
> +      TRY_CATCH (e, RETURN_MASK_ERROR)
> +	{
> +	  bpstat_do_actions (&stop_bpstat);
> +	}

Will things go bad if RETURN_QUIT?  I discovered that we don't handle
quit very well from some places.

Easy to trigger; put a command that generates lots of paginated output
in the commands list and press q at the page prompt.

-- 
Daniel Jacobowitz
CodeSourcery



More information about the Gdb-patches mailing list