[rfc] Fix info spu mailbox command
Markus Deuling
deuling@de.ibm.com
Wed Mar 19 18:50:00 GMT 2008
Joel Brobecker schrieb:
> Hi Markus,
>
>> +set msg "info spu mailbox"
>> +gdb_test_multiple "info spu mailbox " $msg {
>> + -re "SPU Outbound Mailbox.*0x00000000.*SPU Outbound Interrupt Mailbox.*0x00000000.*$gdb_prompt $" \
>> + { pass $msg }
>> + default {
>> + xfail $msg
>> + }
>> +}
>
> After having looked at your previous patch, it looks like you probably
> wanted to only xfail the test when the 0x number (mailbox number?) is
> 0xc0000000, but anything else is an unexpected FAIL. Also, I don't think
> you need the "default" block. So I think your test should look like this:
>
> gdb_test_multiple "info spu mailbox" "$msg" {
> -re "SPU Outbound Mailbox.*0x00000000.*SPU Outbound Interrupt Mailbox.*0x00000000.*$gdb_prompt $" {
> pass "$msg"
> }
> -re "SPU Outbound Mailbox.*0xc0000000.*SPU Outbound Interrupt Mailbox.*0xc0000000.*$gdb_prompt $" {
> xfail "$msg"
> }
> }
>
Hm, yes and no. Maybe it was not a good idea from me to check for 0xc.... Before that kernel patch
the data came from an uninitialised variable so it might have been 0xc... accidently.
I haven't seen cases != 0xc but this does not mean that this can't happen.
Only thing I can say for sure is that 0x00000000 should be the initial content. Everything else is
XFAIL because of old kernel version.
--
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com
More information about the Gdb-patches
mailing list