[rfc] Fix info spu mailbox command

Joel Brobecker brobecker@adacore.com
Wed Mar 19 18:33:00 GMT 2008


Hi Markus,

> +set msg "info spu mailbox"
> +gdb_test_multiple "info spu mailbox " $msg {
> +  -re "SPU Outbound Mailbox.*0x00000000.*SPU Outbound Interrupt Mailbox.*0x00000000.*$gdb_prompt $" \
> +    { pass $msg }
> +  default {
> +    xfail $msg
> +  }
> +}

After having looked at your previous patch, it looks like you probably
wanted to only xfail the test when the 0x number (mailbox number?) is
0xc0000000, but anything else is an unexpected FAIL. Also, I don't think
you need the "default" block. So I think your test should look like this:

gdb_test_multiple "info spu mailbox" "$msg" {
    -re "SPU Outbound Mailbox.*0x00000000.*SPU Outbound Interrupt Mailbox.*0x00000000.*$gdb_prompt $" {
         pass "$msg"
    }
    -re "SPU Outbound Mailbox.*0xc0000000.*SPU Outbound Interrupt Mailbox.*0xc0000000.*$gdb_prompt $" {
         xfail "$msg"
    }
}

-- 
Joel



More information about the Gdb-patches mailing list