[RFA] Add comments to linux-nat.c
Vladimir Prus
vladimir@codesourcery.com
Thu Jun 26 15:56:00 GMT 2008
On Thursday 26 June 2008 17:51:49 Daniel Jacobowitz wrote:
> On Sat, Jun 14, 2008 at 06:29:05PM +0400, Vladimir Prus wrote:
> >
> > With the introduction of async mode, linux-nat.c became even more complex that it
> > was, and it became apparent that some high-level comments are needed. So, I've grabbed
> > Pedro and Dan on IRC and extracted the knowledge from their heads into a text file.
> > Here's the result. OK?
>
> When you get a chance, could you repost this with Eli's comments
> addressed? Here's a few more but the content looks fine.
>
> > +/* This comments documents high-level logic of this file.
>
> This comment documents the, or These comments document the.
>
> > +blocked, the signal becomes pending and sigsuspend, presumably, immediately
> > +noticed it and returns.
>
> s/presumably, //. You're correct. Also noticed -> notices.
>
> > +The main design point is that every time GDB is outside linux-nat.c, we have a
> > +SIGCLD handler installed that is called when something happens to the target
>
> SIGCHLD
Here's a version with comments from Eli and you addressed. OK?
- Volodya
-------------- next part --------------
A non-text attachment was scrubbed...
Name: linux-nat.diff
Type: text/x-diff
Size: 8568 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20080626/6c2e48f5/attachment.bin>
More information about the Gdb-patches
mailing list