[patch]: Fix memory leak of c-exp.y

teawater teawater@gmail.com
Wed Jun 25 12:32:00 GMT 2008


On Tue, Jun 24, 2008 at 21:35, Jan Kratochvil <jan.kratochvil@redhat.com> wrote:
> On Tue, 24 Jun 2008 08:32:44 +0200, teawater wrote:
>> ChangeLog:
>> 2008-06-21  Hui Zhu <teawater@gmail.com>
>>        * gdb/c-exp.y: Fix memory leak of function parse_number
>
> Agreed with the fix just IMO the block of code needs more cleanups.  [attached]
> The leak was brought in by:
>  http://sourceware.org/ml/gdb-patches/2007-10/msg00395.html
>
> Just please check the GNU Coding Standards document for the ChangeLog style, it
> should have been more like:
>
> 2008-06-21  Hui Zhu  <teawater@gmail.com>
>
>        * c-exp.y (parse_number): Fix a memory leak.
>

OK. Thank you Jan.

Hui



More information about the Gdb-patches mailing list