functions that delete breakpoints should not insert bp locations (was: Fix execl.exp sporadic failures)

Daniel Jacobowitz drow@false.org
Mon Jul 7 19:06:00 GMT 2008


On Thu, Jul 03, 2008 at 11:45:53AM +0100, Pedro Alves wrote:
> 2008-07-03  Pedro Alves  <pedro@codesourcery.com>
> 
> 	* breakpoint.c (update_global_location_list): Add boolean
> 	"should_insert" argument.  Only insert locations if caller told it
> 	too.
> 	(update_global_location_list_nothrow): Add boolean "should_insert"
> 	argument.  Pass it to update_global_location_list.
> 	(insert_breakpoints, create_longjmp_breakpoint)
> 	(create_overlay_event_breakpoint, enable_overlay_breakpoints)
> 	(create_thread_event_breakpoint, create_solib_event_breakpoint)
> 	(create_fork_vfork_event_catchpoint, create_exec_event_catchpoint)
> 	(enable_watchpoints_after_interactive_call_stop)
> 	(set_momentary_breakpoint, create_breakpoints)
> 	(break_command_really, watch_command_1)
> 	(create_ada_exception_breakpoint, update_breakpoint_locations)
> 	(do_enable_breakpoint, enable_command): Pass true to
> 	update_global_location_list.
> 	(bpstat_stop_status, disable_overlay_breakpoints)
> 	(disable_watchpoints_before_interactive_call_start)
> 	(delete_breakpoint, disable_breakpoint, disable_command): Pass
> 	false to update_global_location_list.
> 	(update_breakpoints_after_exec): Don't temporarily disable
> 	always-inserted mode.

Thanks, this is OK.

-- 
Daniel Jacobowitz
CodeSourcery



More information about the Gdb-patches mailing list