[Patch] Fix for -var-update to use natural format to compare

Vladimir Prus vladimir@codesourcery.com
Tue Jan 22 17:50:00 GMT 2008


Marc Khouzam wrote:

> 
>> I think there are actually two different problems:
>> 
>> 1. Given single varobj that is displayed in one format, how does one
>> one if the value is "really changed". The answer here is that you don't
>> get to find that -- -var-update reports only changes in displayed
>> value, and since changing format is fast, nothing else is needed here.
> 
> Ok.
> 
>> 2. If UI wishes to show varobj in several formats, how does it
>> figure out of *any* of formats has changed. There are two possible
>> solutions:
>> 
>>    (a) Always keep varobj (from frontnend) in natural format, and assume
>>      that if natural format changes, all values possibly change. In this
>>      case, getting a value in different format will involve switching
>>      to that format and then switching back.
> 
> That is what I will do.
> If it is the best thing for GDB to make this a requirement for a frontend
> that wants to show mutliple formats, may I suggest that it be added to the
> documentation of var-update?  A short mention that "if a frontend
> wants to be notified of a change in any format, it should keep the
> variable object in the natural format".

It's good to improve docs in this way. It should be noted that this
might not be true in future, say when we add Python scripting,  or
(maybe) when we'll add a way to specify floating point precision.

> Also, if GDB requires this of frontends showing mutliple formats, it would
> be nice to have -var-evaluate-expression take a format as an optional
> parameter.  Then, the frontend would not need to use -var-set-format
> to get a different formatted value, and could keep the variable object
> in the natural format at all times.
> 
> I can provide a patch if this is a supported idea.

I personally think this is a good idea! It means that if we for example 
need to quickly show some value in specific format, like hex value in tooltip,
we don't need two format setting commands before and after. So, such
a patch will be valuable independently of how -var-update operates.

- Volodya




More information about the Gdb-patches mailing list