[RFA] Refactor bpstat_stop_status.

Vladimir Prus vladimir@codesourcery.com
Thu Apr 24 14:08:00 GMT 2008


On Monday 17 December 2007 02:01:08 Daniel Jacobowitz wrote:
> On Sun, Dec 16, 2007 at 10:10:28PM +0300, Vladimir Prus wrote:
> >     	* breakpoint.c (check_location)
> >     	(check_watchpoint, check_breakpoint_conditions):
> >     	New, extracted from bpstat_stop_status.
> >     	(bpstat_stop_status): Use the above.
> 
> The patch seems fine, but these function names are too generic - they
> say what they are checking, but not what they are checking for.
> There's already a watchpoint_check which does something different
> from check_watchpoint.
> 
> How about a bp_stop_ prefix?

I've added such a prefix and checked in the attached.

- Volodya
-------------- next part --------------
A non-text attachment was scrubbed...
Name: commit.diff
Type: text/x-diff
Size: 19058 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20080424/df2dd155/attachment.bin>


More information about the Gdb-patches mailing list