Your sim testsuite changes broke other targets

M R Swami Reddy MR.Swami.Reddy@nsc.com
Tue Apr 8 12:03:00 GMT 2008


Hi,

Opps, sorry for this.

Fixed this issue. Please find the attached patch file and let me know if this ok 
to apply?

ChangeLog:
====
2008-04-08  M R Swami Reddy <MR.Swami.Reddy@nsc.com>

         * allinsn.exp: Moved target_alias and global_ld_options into
         if condition
====

Thanks,
Swami

Hans-Peter Nilsson wrote:
> All tests broke for all targets in my sim autotester.  For
> *some* reason, they now want to run cr16-elf-as for the tests...
> 
> 2008-02-12  M Ranga Swami Reddy <MR.Swami.Reddy@nsc.com>
> 
> 	* sim/cr16/: New directory. Tests for CR16 simulator.
> 	sim/cr16/allinsn.exp and sim/cr16/misc.exp: New files: Test scripts.
> 
> At the top of that allinsn.exp:
> 
> ------
> # CR16 simulator testsuite.
> 
> set target_alias cr16-elf
> set global_ld_options "-L/local/user/swami/cr16-5.1/build/CR_R_2007-08-24_11-34-56/release/linux/lib/gcc/cr16-elf/4.1.2 -T/home10/swami/dummy.ld"
> 
> if [istarget cr16*-*-*] {
> ...
> ------
> 
> I think I see why!  (Hint: they aren't cr16-elf. ;)
> 
> Did you really mean to commit with those "set"s there?  Please
> remove them; they look wrong.  At least move them inside the
> "if".  (If you remove them, I'll consider adding cr16 to the
> targets I test in my autotester.)
> 
> brgds, H-P
> 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: allinsn.exp.patch
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20080408/a0acae8d/attachment.ksh>


More information about the Gdb-patches mailing list