[rfc] Multi-threaded watchpoints, GNU/Linux native bits

Luis Machado luisgpm@linux.vnet.ibm.com
Mon Sep 17 14:15:00 GMT 2007


>  static int
> -ppc_linux_stopped_by_watchpoint (void)
> +ppc_linux_stopped_data_address (struct target_ops *target, CORE_ADDR *addr_p)
>  {
> -  int tid;
> -  struct siginfo siginfo;
> -  ptid_t ptid = inferior_ptid;
> +  struct siginfo *siginfo_p;
>    CORE_ADDR *addr_p;
> 
> -  tid = TIDGET(ptid);
> -  if (tid == 0)

Quick comment:

"CORE_ADDR *addr_p" right below "siginfo_p" should be eliminated since
we're already getting that parameter from the function call.

Regards,
 
Luis Machado
IBM Linux Technology Center
e-mail: luisgpm@linux.vnet.ibm.com



More information about the Gdb-patches mailing list