[RFA/commit] Delete breakpoint:set_breakpoint_sal()

Joel Brobecker brobecker@adacore.com
Mon Oct 29 14:47:00 GMT 2007


Hello,

It looks like this function is no longer used. I checked all of gdb
and gdbtk. Is there any other place where I should check? The command
I used at the root of src is:

    % find . -type f -print | xargs grep set_breakpoint_sal

2007-10-29  Joel Brobecker  <brobecker@adacore.com>

        * breakpoint.h (set_breakpoint_sal): Remove declaration.
        * breakpoint.c (set_breakpoint_sal): Delete.

Tested on x86-linux by rebuilding GDB. Objections or comments?

-- 
Joel
-------------- next part --------------
Index: breakpoint.h
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.h,v
retrieving revision 1.52
diff -u -p -r1.52 breakpoint.h
--- breakpoint.h	1 Oct 2007 00:17:58 -0000	1.52
+++ breakpoint.h	29 Oct 2007 13:56:06 -0000
@@ -848,8 +848,6 @@ extern int ep_is_catchpoint (struct brea
    such as a library load or unload. */
 extern int ep_is_shlib_catchpoint (struct breakpoint *);
 
-extern struct breakpoint *set_breakpoint_sal (struct symtab_and_line);
-
 /* Enable breakpoints and delete when hit.  Called with ARG == NULL
    deletes all breakpoints. */
 extern void delete_command (char *arg, int from_tty);
Index: breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.274
diff -u -p -r1.274 breakpoint.c
--- breakpoint.c	12 Oct 2007 16:11:11 -0000	1.274
+++ breakpoint.c	29 Oct 2007 13:56:06 -0000
@@ -6982,19 +6982,6 @@ catch_command_1 (char *arg, int tempflag
     }
 }
 
-/* Used by the gui, could be made a worker for other things. */
-
-struct breakpoint *
-set_breakpoint_sal (struct symtab_and_line sal)
-{
-  struct breakpoint *b;
-  b = set_raw_breakpoint (sal, bp_breakpoint);
-  set_breakpoint_count (breakpoint_count + 1);
-  b->number = breakpoint_count;
-  b->thread = -1;
-  return b;
-}
-
 static void
 catch_command (char *arg, int from_tty)
 {


More information about the Gdb-patches mailing list