[rfc] [1/6] Remove macro CALL_DUMMY_LOCATION

Markus Deuling deuling@de.ibm.com
Thu May 31 11:18:00 GMT 2007


Hi Jim,

Jim Blandy wrote:
> Markus Deuling <deuling@de.ibm.com> writes:
>> this patch removes CALL_DUMMY_LOCATION macro from gdbarch.sh.
>>
>> ChangeLog:
>>
>> 	* gdbarch.sh (CALL_DUMMY_LOCATION): Replace by
>> 	gdbarch_call_dummy_location.
>> 	* infcall.c (call_function_by_hand): Likewise.
>> 	* inferior.h: Change comment.
>> 	* arch-utils.c: Change comment.
>> 	* gdbarch.c, gdbarch.h: Regenerate.
>>
>>
>> Is this ok to commit?
> 
> This looks good --- thank you!

thank you very much for your review.

I attached a new version of the patch where I deleted a unnecessary comment
instead of rewriting it.

-#include "inferior.h" /* enum CALL_DUMMY_LOCATION et.al. */
+#include "inferior.h" 

If that's ok, could you please commit it Ulrich? Thanks in advance.

-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com



-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: diff-remove-CALL_DUMMY_LOCATION
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20070531/f1c445b3/attachment.ksh>


More information about the Gdb-patches mailing list