[RFA] wrong pointer type length part 2 (of 2)
Joel Brobecker
brobecker@adacore.com
Thu May 17 18:51:00 GMT 2007
> > > As a followup to this patch, I think that the same needs to be done
> > > for at least make_reference_type, but I don't have hard evidence that
> > > this will ever be needed right now. If it is agreed that this function
> > > also needs an update, it can be made independently in a followup patch.
> >
> > Yes please.
>
> I'm working on the second part right now...
OK, here is the second part that deals with reference types.
2007-05-17 Joel Brobecker <brobecker@adacore.com>
* gdbtypes.c (make_reference_type): Preserve the type chain
and set the length of all the variants of the pointer type.
Tested on x86-linux (elf/dwarf), and ppc-aix (xcoff/stabs).
OK to commit?
Thanks,
--
Joel
-------------- next part --------------
Index: gdbtypes.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtypes.c,v
retrieving revision 1.115
diff -u -p -r1.115 gdbtypes.c
--- gdbtypes.c 17 May 2007 16:38:25 -0000 1.115
+++ gdbtypes.c 17 May 2007 16:40:53 -0000
@@ -354,6 +354,7 @@ make_reference_type (struct type *type,
{
struct type *ntype; /* New type */
struct objfile *objfile;
+ struct type *chain;
ntype = TYPE_REFERENCE_TYPE (type);
@@ -379,7 +380,9 @@ make_reference_type (struct type *type,
{
ntype = *typeptr;
objfile = TYPE_OBJFILE (ntype);
+ chain = TYPE_CHAIN (ntype);
smash_type (ntype);
+ TYPE_CHAIN (ntype) = chain;
TYPE_OBJFILE (ntype) = objfile;
}
@@ -395,6 +398,14 @@ make_reference_type (struct type *type,
if (!TYPE_REFERENCE_TYPE (type)) /* Remember it, if don't have one. */
TYPE_REFERENCE_TYPE (type) = ntype;
+ /* Update the length of all the other variants of this type. */
+ chain = TYPE_CHAIN (ntype);
+ while (chain != ntype)
+ {
+ TYPE_LENGTH (chain) = TYPE_LENGTH (ntype);
+ chain = TYPE_CHAIN (chain);
+ }
+
return ntype;
}
More information about the Gdb-patches
mailing list