[commit] Reduce target_thread_alive calls on GNU/Linux

Mark Kettenis mark.kettenis@xs4all.nl
Mon May 7 07:27:00 GMT 2007


> Date: Sun, 6 May 2007 20:49:09 -0400
> From: Daniel Jacobowitz <drow@false.org>
> Index: gdb/linux-thread-db.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/linux-thread-db.c,v
> retrieving revision 1.26
> diff -u -p -r1.26 linux-thread-db.c
> --- gdb/linux-thread-db.c	5 Feb 2007 20:02:51 -0000	1.26
> +++ gdb/linux-thread-db.c	6 May 2007 15:31:41 -0000
> @@ -486,9 +481,9 @@ enable_thread_event_reporting (void)
>    td_event_addset (&events, TD_CREATE);
>  
>  #ifdef HAVE_GNU_LIBC_VERSION_H
> -  /* FIXME: kettenis/2000-04-23: The event reporting facility is
> -     broken for TD_DEATH events in glibc 2.1.3, so don't enable it for
> -     now.  */
> +  /* The event reporting facility is broken for TD_DEATH events in
> +     glibc 2.1.3, so don't enable it we have glibc but a lower
> +     version.  */
>    libc_version = gnu_get_libc_version ();
>    if (sscanf (libc_version, "%d.%d", &libc_major, &libc_minor) == 2
>        && (libc_major > 2 || (libc_major == 2 && libc_minor > 1)))

I think there is a missing "if" in that comment.

Mark



More information about the Gdb-patches mailing list