[RFC] -thread-select double print stack frame

Denis PILAT denis.pilat@st.com
Thu Mar 29 07:45:00 GMT 2007


>> I do run the testsuite on i386-linux native target, no regression at all.
>> Can I commit or not ?
>>     
>
> Yes, go ahead.  Thanks.
>
>   

Just committed !
Attached is the patch:
-- 
Denis

2007-03-29  Denis Pilat  <denis.pilat@st.com>

	* stack.c (print_stack_frame): Always use LOC_AND_ADDRESS in MI output.
	* infrun.c (normal_stop): Remove MI specific frame printing treatment.

Index: stack.c
===================================================================
RCS file: /cvs/src/src/gdb/stack.c,v
retrieving revision 1.142
diff -u -p -r1.142 stack.c
--- stack.c     27 Feb 2007 19:46:04 -0000      1.142
+++ stack.c     26 Mar 2007 13:14:25 -0000
@@ -105,7 +105,8 @@ print_stack_frame (struct frame_info *fr

  args.frame = frame;
  args.print_level = print_level;
-  args.print_what = print_what;
+  /* For mi, alway print location and address.  */
+  args.print_what = ui_out_is_mi_like_p (uiout) ? LOC_AND_ADDRESS : print_what;
  args.print_args = 1;

  catch_errors (print_stack_frame_stub, &args, "", RETURN_MASK_ALL);
Index: infrun.c
===================================================================
RCS file: /cvs/src/src/gdb/infrun.c,v
retrieving revision 1.223
diff -u -p -r1.223 infrun.c
--- infrun.c    9 Mar 2007 16:20:42 -0000       1.223
+++ infrun.c    26 Mar 2007 13:14:39 -0000
@@ -3200,10 +3200,6 @@ Further execution is probably impossible
           default:
             internal_error (__FILE__, __LINE__, _("Unknown value."));
           }
-         /* For mi, have the same behavior every time we stop:
-            print everything but the source line. */
-         if (ui_out_is_mi_like_p (uiout))
-           source_flag = LOC_AND_ADDRESS;

         if (ui_out_is_mi_like_p (uiout))
           ui_out_field_int (uiout, "thread-id",




More information about the Gdb-patches mailing list