[Patch]: Little Cleanup

Mark Kettenis mark.kettenis@xs4all.nl
Mon Mar 5 21:23:00 GMT 2007


> Date: Mon, 05 Mar 2007 23:04:48 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > Date: Mon, 05 Mar 2007 06:57:50 +0100
> > From: Markus Deuling <deuling@de.ibm.com>
> > CC: Pedro Alves <pedro_alves@portugalmail.pt>, gdb-patches@sourceware.org
> > 
> >        if (!breakpoints_inserted && !ecs->another_trap)
> >  	{
> > -	  breakpoints_failed = insert_breakpoints ();
> > -	  if (breakpoints_failed)
> > +          if (insert_breakpoints () != 0)
> >  	    {
> >  	      stop_stepping (ecs);
> >  	      return;
> 
> I thought we agreed about adding a comment here, something like:
> 
>   /* insert_breakpoints returns non-zero if it fails to insert the
>      breakpoints.  */

Adding this sort of comments at all call sites of such functions is
really silly.

Mark



More information about the Gdb-patches mailing list