[Patch]: Little Cleanup
Markus Deuling
deuling@de.ibm.com
Mon Mar 5 05:59:00 GMT 2007
Hi,
thank you for your comment.
Eli Zaretskii wrote:
>>
>> Actually, I find your version harder to read for someone not knowing the
>> insert_breakpoints API by heart.
>>
>
> FWIW, I agree. The new version requires a comment to be as readable
> as the old one.
>
> (Of course, I'd expect the optimizer to produce the same code from
> both old and new versions.)
I agree.
Comment in insert_breakpoints() says:
"Both return zero if successful, or an `errno' value if ..." so
"if (insert_breakpoints () != 0)" is more clear and precise.
I changed the patch. Ok ?
ChangeLog:
* infrun.c (breakpoints_failed): Remove unnecessary variable.
(handle_inferior_event): Remove unnecessary braces.
* breakpoint.c (bpstat_what): Remove wrong comment.
--
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: cleanup_patch
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20070305/c5bbd4ea/attachment.ksh>
More information about the Gdb-patches
mailing list