[rfc] Replace macros by gdbarch functions in gdbint manual

Markus Deuling deuling@de.ibm.com
Thu Jun 28 10:46:00 GMT 2007


Eli Zaretskii wrote:
>> Date: Wed, 27 Jun 2007 16:11:34 -0400
>> From: Daniel Jacobowitz <drow@false.org>
>> Cc: Markus Deuling <deuling@de.ibm.com>, gdb-patches@sourceware.org, 	uweigand@de.ibm.com
>>
>> On Wed, Jun 27, 2007 at 09:30:19PM +0300, Eli Zaretskii wrote:
>>>> +the inferior function onto the stack.  In addition to pushing @var{nargs}, the
>>>> +code should push @var{struct_addr} (when @var{struct_return}), and the return
>>>                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^
>>> It looks like something is missing in the parens.  The old text also
>>> had this problem; can someone suggest or guess what was meant here?
>> It's unclear wording, but I understand it; struct_return is
>> essentially a boolean condition here.  And there's a flag variable of
>> the same name in call_function_by_hand.
> 
> So it should say "when @var{struct_return} is non-zero", right?
> 
> Or maybe, since you say this is the name of an actual variable, use
> @code{struct_return} instead of @var?
> 

Ok, I added "is non-zero".

+@anchor{gdbarch_push_dummy_call} Define this to push the dummy frame's call to
+the inferior function onto the stack.  In addition to pushing @var{nargs}, the
+code should push @var{struct_addr} (when @var{struct_return} is non-zero), and
+the return address (@var{bp_addr}).


-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: diff-gdbint
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20070628/bfafd524/attachment.ksh>


More information about the Gdb-patches mailing list