[rfc] Remove macros {SP,PC,PS,FP0}_REGNUM from gdbarch.sh

Markus Deuling deuling@de.ibm.com
Wed Jun 13 17:49:00 GMT 2007


Eli Zaretskii wrote:
>> Date: Wed, 13 Jun 2007 15:17:23 +0200
>> From: Markus Deuling <deuling@de.ibm.com>
>> CC: Ulrich Weigand <uweigand@de.ibm.com>
>>
>> this patch removes following macros from gdbarch.sh:
>>
>> * SP_REGNUM
>> * PC_REGNUM
>> * PS_REGNUM
>> * FP0_REGNUM
> 
> You do this in go32-nat.c, which I think will break the DJGPP port,
> because AFAIK it doesn't support gdbarch.
> 

Hm, the only of these 4 macros used in g032-nat.c is FP0_REGNUM. I don't see any
other definition of FP0_REGNUM beside the one in gdbarch.h

#if !defined (GDB_TM_FILE) && defined (FP0_REGNUM)
#error "Non multi-arch definition of FP0_REGNUM"
#endif
#if !defined (FP0_REGNUM)
#define FP0_REGNUM (gdbarch_fp0_regnum (current_gdbarch))
#endif

So go32-nat.c uses gdbarch_fp0_regnum, doesn't it? What am I overseeing?
Thank you very much for your review.


-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com



More information about the Gdb-patches mailing list