[PATCH] null pointer guard, target-descriptions.c
msnyder@sonic.net
msnyder@sonic.net
Tue Jul 3 00:40:00 GMT 2007
> On Thu, Jun 28, 2007 at 02:01:03PM -0700, Michael Snyder wrote:
>> Possible null pointer ref, flagged by Coverity
>>
>
>> 2007-06-28 Michael Snyder <msnyder@access-company.com>
>>
>> * target-descriptions.c (tdesc-_named_type): Guard against null
>> type-id argument which may be passed by tdesc_create_reg (Coverity).
>
> Whoops, yeah - this one's my fault. There's another place in the same
> file which will crash if reg->type == NULL. How about we never set it
> to NULL instead? Like below.
That certainly solves the issue for now -- since it's only called
from one place -- but if we just went ahead and checked it for null,
we wouldn't have to worry about it coming up again.
But it's your code, so your choice... if you prefer your patch,
consider this approval. ;-)
More information about the Gdb-patches
mailing list