[rfc] Overflow in transfer-rate

Denis PILAT denis.pilat@st.com
Mon Jul 2 07:36:00 GMT 2007


Daniel Jacobowitz wrote:
> On Mon, Jun 11, 2007 at 03:15:41PM +0200, Denis PILAT wrote:
>   
>> Andrew STUBBS wrote:
>>     
>>> Denis PILAT wrote:
>>>       
>>>> In symfile.c/print_transfer_performance (), an overflow can occure when 
>>>> data_count (see below) is a large number.
>>>>
>>>> I propose either the following 1st patch, or to pass to "%llu"into the 
>>>> ui_out_field_fmt functino call, see the next patch proposal.
>>>>         
>>> I might also be worth taking a look at this proposal from some time ago 
>>> http://www.cygwin.com/ml/gdb-patches/2006-10/msg00184.html
>>>
>>>       
>> Well, it sounds like an internal ST discussion but I prefer the patch in your 
>> link, it avoids overflow *and* prints transfer rate in a much clever way.
>>     
>
> How about this version, then?  I left GDB/MI behavior unchanged, so
> that this does not break GUIs.
>
>   
Hi Daniel,

You're right, we must not break MI based GUI, I'm fine with your proposal.
I guess it will be include in 6.8 , not 6.7 GDB version ?

Thanks,
Denis



More information about the Gdb-patches mailing list