[RFC] varobj deletion after the binary has changed

Denis PILAT denis.pilat@st.com
Wed Jan 31 19:07:00 GMT 2007


Nick Roberts wrote:
>  
> Looks good.  Maybe varobj_update could use an enum:
>
> enum varobj_update_values
>   {
>     SCOPE_FALSE = -1,
>     TYPE_CHANGED,
>     SCOPE_INVALID
>   }
>   
Yes, it's better and more readable.
As you'll see in my patch, the varobj_update function could return more 
than these case of error, it's the caller that decides how to deal with 
these errors.
>
> (It looks like we could remove the return value of varobj_update_one as it
> doesn't seem to be used.)
>   
You're right, I removed it as well.

Attached is the new implementation plus the new exp file.

Denis
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: varobj.patch
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20070131/78b13962/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: mi-var-invalidate.exp
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20070131/78b13962/attachment-0001.ksh>


More information about the Gdb-patches mailing list