[RFA]: gdb/testsuite/gdb.arch/altivec-regs.exp Broken testcase

[Markus Deuling]

Hi,

I'm referring to http://sourceware.org/ml/gdb-patches/2007-01/msg00353.html.

It seems that the output from "show endian" has changed since the last time someone took a 
look into it :-) So I added a "re" to the test.

Do we need this branch or can I delete it ?
>>     -re "(The target endianness is set automatically .currently )(big|little)( endian.*)$gdb_prompt $" {
>>         pass "endianness"
>>        set endianness $expect_out(2,string)
>>     }

This is the result of gdb.arch/altivec-regs.exp with my patch:

# of expected passes            209
# of unexpected failures        1


Is it ok to apply ?

ChangeLog:

       *gdb.arch/altivec-regs.exp: Initialise variable
       endianness in every case. 

==========================================
diff -urN dev/gdb/testsuite/gdb.arch/altivec-regs.exp src/gdb/testsuite/gdb.arch/altivec-regs.exp
--- dev/gdb/testsuite/gdb.arch/altivec-regs.exp 2007-01-10 15:48:12.000000000 +0100
+++ src/gdb/testsuite/gdb.arch/altivec-regs.exp 2007-01-16 07:40:05.000000000 +0100
@@ -88,12 +88,17 @@

 gdb_test "next" "" ""

+set endianness ""
 send_gdb "show endian\n"
 gdb_expect {
     -re "(The target endianness is set automatically .currently )(big|little)( endian.*)$gdb_prompt $" {
         pass "endianness"
        set endianness $expect_out(2,string)
     }
+    -re "The target is assumed to be big endian.*" {
+        pass "endianess"
+        set endianness "big"
+    }
     -re ".*$gdb_prompt $" {
        fail "couldn't get endianness"
     }


Regards,
Markus

-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com