[mi] [ada] varobjs for registers 2

[Vladimir Prus]

Eli Zaretskii wrote:

>> From: Vladimir Prus <vladimir@codesourcery.com>
>> Date: Wed, 20 Dec 2006 21:37:28 +0300
>> 
>> This is a second revision of the patch to add MI command that
>> creates varobjs for registers. The command is renamed to -var-list
>> and used like:
>> 
>> -var-list --registers
>> 
>> There are now docs and tests. The created variable objects no longer
>> have 'public' pseudo-fields, no matter what the language of the program
>> is.
>> 
>> Along the way, I've promoted a private function in ada-lang.c to
>> language.c, so I'd appreciate if Ada maintainers take a quick look.
>> 
>> OK?
> 
> Thanks.
> 
> The patch for the manual is approved, but please take care of these
> minor problems:
> 
>> +This command is intended to efficiently create a number of variable
>> +objects---for example for registers, or for local variables.  Using
>> +the @code{-var-create} command would not be ideal, because it must be
>> +issued once for every variable object.
> 
> Please add a cross-reference to the description of -var-create here.

Is 

   Using the @code{-var-create} (@pxref{-var-list-children}) command

the right texinfo way to do a reference?

>> +a list of tuples.  Each tuple describes a single variable object in
>> +the same was as for the @code{-var-create} command:
>    ^^^^^^^^^^^^^^^^^^^
> Something's wrong here.

It meant to be:

   the same way as for the @code{-var-create} command:


Revised patch attached. In addition to the changes you've suggested, I've
reworded the first paragraph to more explicitly document that -var-list
tries to return previously-created varobjs, as Nick and I discussed.

OK?

- Volodya

-------------- next part --------------
A non-text attachment was scrubbed...
Name: varobj_for_registers__gdb_mainline.diff
Type: text/x-diff
Size: 11339 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20070105/bbe7b2b3/attachment.bin>