Simpify varobj children handling for C

[Daniel Jacobowitz]

On Sat, Dec 23, 2006 at 10:51:55PM +0300, Vladimir Prus wrote:
> This patch introduces new function c_describe_child that can return
> name, value and type at the same time. The three function mentioned
> above are made a tiny wrapeprs over c_describe_child.

Looks pretty good to me.  I'll give you some cosmetic tips, but other
than that this is OK.

> 	Simplify access to various properties of children
> 	variable objects in C.

"child variable objects"; "child" describes "variable objects", but
you can't use a plural for that.

> +/* Return the value of element TYPE_INDEX of a structure
> +   value VALUE.  VALUE's type should be either structure,
> +   or union, or a typedef to struct/union.  

"should be a structure" - you've got a list of three, so "either"
is inappropriate.

> +  struct type * type = value_type (value);

No space after *, please :-)

-- 
Daniel Jacobowitz
CodeSourcery