[RFC] varobj deletion after the binary has changed

Denis PILAT denis.pilat@st.com
Tue Feb 13 08:26:00 GMT 2007


Nick Roberts wrote:
>  > Thanks you for the documentation update.
>  > Hereby is 2 patches I would like to commit, the C part and the new . exp 
>  > file.
>  > I change the .exp file with your comment, with a newer copyright notice, 
>  > and with including value field in output of -var-create.
>  > I also changed a comment plus typos in the C code.
>  > 
>  > Daniel already approved the sources, Eli is near to be fine with the doc.
>  > Could have a look once more into the  following, at least for the 
>  > ChangeLog entry ?
>  > Then how could we synchronize our commit ?
>
> I've committed my documentation with requested changes (see below).  All you
> need to do is commit yours.
>
>  > 2007-02-12  Denis Pilat  <denis.pilat@st.com>
>  > 
>  > 	* gdb.mi/mi-var-invalidate.exp: New files.
>
>                                         New file.
>
>  > 2007-02-12  Denis Pilat  <denis.pilat@st.com>
>  > 
>  > 	* varobj.c (struct varobj_root): Add is_valid member.
>  > 	(varobj_get_type): Check for invalid varobj.
>  > 	(varobj_get_attributes): Likewise.
>  > 	(variable_editable):Likewise.
>  > 	(varobj_update): Likewise plus use an enum for returned error values.
>  > 	(new_root_variable): Set root varobj as valid by default.
>  > 	(varobj_invalidate): New function.
>  > 	* varobj.h (enum varobj_update_error): New enum.
>  > 	(varobj_invalidate): New function.
> duplicate entry
>
>  > 	* symfile.c (clear_symtab_users): Use varobj_invalidate.
>  > 	* mi/mi-cmd-var.c (varobj_update_one): Change returned type to void and
>  > 	use of new enum varobj_update_error to deal with errors.
>
>  	* varobj.h (enum varobj_update_error): New enum.
>  	* varobj.c (struct varobj_root): Add is_valid member.
>  	(varobj_get_type): Check for invalid varobj.
>  	(varobj_get_attributes): Likewise.
>  	(variable_editable):Likewise.
>  	(varobj_update): Likewise.  Use varobj_update_error.
>  	(new_root_variable): Set root varobj as valid by default.
>  	(varobj_invalidate): New function.
>  	* symfile.c (clear_symtab_users): Use varobj_invalidate.
>  	* mi/mi-cmd-var.c (varobj_update_one): Change return type to void.
>   	Use varobj_update_error.
>
> (Suggestion)
>
>   
The following has just been committed:
- symfile.c, varobj.c, varobj.h, mi/mi-cmd-var.c
- testsuite/gdb.mi/mi-var-invalidate.exp

-- 
Denis



More information about the Gdb-patches mailing list