[RFC] varobj deletion after the binary has changed

Eli Zaretskii eliz@gnu.org
Fri Feb 9 15:43:00 GMT 2007


> From: Nick Roberts <nickrob@snap.net.nz>
> Date: Fri, 9 Feb 2007 08:33:08 +1300
> Cc: Denis PILAT <denis.pilat@st.com>, 	gdb-patches <gdb-patches@sourceware.org>
> 
> How about this?

Approved, provided that you fix the following:

> + @item
> + The range of values for fields with specified values e.g in_scope,
> + type_changed may be extended.

First, "e.g" lacks the second period and a comma after it ("e.g.,").

Second, in_scope and type_changed should be in @code or @samp.

Third, these two are not mentioned anywhere in the node you are
patching, so please either add a cross-reference to where they are
described or add some minimal description to the text.

>   Reevaluate the expressions corresponding to the variable object
>   @var{name} and all its direct and indirect children, and return the
> ! list of variable objects whose values have changed.  @var{name} must
> ! be a root variable object.

The last sentence will begin with a non-capital letter, which is not
valid English.  How about using `;' instead of a period before
@var{name}?

Thanks.



More information about the Gdb-patches mailing list