Formatting changes to mi-main.c

Eli Zaretskii eliz@gnu.org
Sat Feb 3 11:37:00 GMT 2007


> From: Nick Roberts <nickrob@snap.net.nz>
> Date: Sat, 3 Feb 2007 18:43:46 +1300
> 
> 2007-02-03  Nick Roberts  <nickrob@snap.net.nz>
> 
> 	* mi/mi-main.c: Numerous formatting changes.

Thanks for taking care of this.

However:

> *** 40,46 ****
>   #include "interps.h"
>   #include "event-loop.h"
>   #include "event-top.h"
> ! #include "gdbcore.h"		/* for write_memory() */
>   #include "value.h"
>   #include "regcache.h"
>   #include "gdb.h"
> --- 40,46 ----
>   #include "interps.h"
>   #include "event-loop.h"
>   #include "event-top.h"
> ! #include "gdbcore.h"		/* For write_memory().  */

Do the GNU coding standards require that even comments that are not
alone on their lines be complete sentences?  I didn't think they do,
and a quick look in standards.texi didn't find such a guideline.
Personally, I like the brief comment style in the original better.

Anyway, the above isn't a complete sentence anyway, even if we begin
it with a capital letter and end it with a period.

Lastly, if, while at that, you find "foo()" being used as a reference
to the function `foo', please change it to `foo'; that part _is_ in
GNU coding standards.

Thanks again.



More information about the Gdb-patches mailing list